From 58bbf82a5690ca1d1c58a2666222a9b7343a96aa Mon Sep 17 00:00:00 2001 From: Aditya Wasan Date: Fri, 8 Jan 2021 03:38:45 +0530 Subject: Fix auth modes not displaying properly (#1271) * res: fix auth modes not displaying properly Signed-off-by: Aditya Wasan * res: wrap onboarding flow screens inside ScrollView Signed-off-by: Aditya Wasan (cherry picked from commit 534269c8fc8fbd9a72e64389564fb0c90365c0c0) --- app/src/main/res/layout/activity_git_clone.xml | 30 +++- app/src/main/res/layout/fragment_clone.xml | 160 +++++++++++---------- app/src/main/res/layout/fragment_key_selection.xml | 16 ++- app/src/main/res/layout/fragment_repo_location.xml | 160 +++++++++++---------- app/src/main/res/values-hdpi/dimens.xml | 7 + app/src/main/res/values/dimens.xml | 4 + app/src/main/res/values/strings.xml | 2 +- 7 files changed, 212 insertions(+), 167 deletions(-) create mode 100644 app/src/main/res/values-hdpi/dimens.xml diff --git a/app/src/main/res/layout/activity_git_clone.xml b/app/src/main/res/layout/activity_git_clone.xml index 7ee64e51..791d5414 100644 --- a/app/src/main/res/layout/activity_git_clone.xml +++ b/app/src/main/res/layout/activity_git_clone.xml @@ -33,7 +33,8 @@ android:id="@+id/label_server_url" android:layout_width="0dp" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_marginStart="8dp" + android:layout_marginTop="8dp" android:hint="@string/server_url" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -53,7 +54,8 @@ android:id="@+id/label_server_branch" android:layout_width="0dp" android:layout_height="wrap_content" - android:layout_margin="8dp" + android:layout_marginStart="8dp" + android:layout_marginTop="8dp" android:hint="@string/server_branch" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" @@ -83,9 +85,11 @@ @@ -95,21 +99,33 @@ style="?attr/materialButtonOutlinedStyle" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:text="@string/connection_mode_ssh_key" /> + android:layout_weight="1" + android:minWidth="0dp" + android:padding="8dp" + android:text="@string/connection_mode_ssh_key" + android:textSize="@dimen/toggle_group_text_size" /> + android:layout_weight="1" + android:minWidth="0dp" + android:padding="8dp" + android:text="@string/connection_mode_basic_authentication" + android:textSize="@dimen/toggle_group_text_size" /> + android:layout_weight="1" + android:minWidth="0dp" + android:padding="8dp" + android:text="@string/connection_mode_openkeychain" + android:textSize="@dimen/toggle_group_text_size" /> + android:background="?attr/colorPrimary"> - + - + - + - + - + - + - + + + + diff --git a/app/src/main/res/layout/fragment_key_selection.xml b/app/src/main/res/layout/fragment_key_selection.xml index 9a391276..f3dd753a 100644 --- a/app/src/main/res/layout/fragment_key_selection.xml +++ b/app/src/main/res/layout/fragment_key_selection.xml @@ -15,7 +15,7 @@ android:layout_width="64dp" android:layout_height="64dp" android:layout_marginStart="32dp" - android:layout_marginTop="100dp" + android:layout_marginTop="@dimen/onboarding_icon_margin_top" android:contentDescription="@string/app_icon_hint" android:src="@mipmap/ic_launcher" app:layout_constraintStart_toStartOf="parent" @@ -23,23 +23,26 @@ diff --git a/app/src/main/res/layout/fragment_repo_location.xml b/app/src/main/res/layout/fragment_repo_location.xml index 9581774e..268907ba 100644 --- a/app/src/main/res/layout/fragment_repo_location.xml +++ b/app/src/main/res/layout/fragment_repo_location.xml @@ -1,86 +1,94 @@ - + android:background="?attr/colorPrimary"> - + - + - + - + - + - + + + + + + - diff --git a/app/src/main/res/values-hdpi/dimens.xml b/app/src/main/res/values-hdpi/dimens.xml new file mode 100644 index 00000000..e48a0198 --- /dev/null +++ b/app/src/main/res/values-hdpi/dimens.xml @@ -0,0 +1,7 @@ + + + 12sp + 50dp + 70dp + 48dp + diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index a76d0bab..d82d030c 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -10,4 +10,8 @@ 16dp 8dp 56dp + 14sp + 100dp + 140dp + 48dp diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index af8fa88a..39e4e883 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -399,7 +399,7 @@ Select if you want to create a local repo or clone a remote repo. Clone Remote Repo Create Local Repo - Select\nGPG\nKey + Select\nGPG Key Select a GPG key to initialize your store with Select key -- cgit v1.2.3