From 82c83a5bedcb71a997e099d782e36e328162d91e Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Sat, 5 Sep 2020 20:31:28 +0530 Subject: GitSettings: use runCatching to replace exception handling Signed-off-by: Harsh Shandilya --- app/src/main/java/com/zeapo/pwdstore/git/config/GitSettings.kt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/zeapo/pwdstore/git/config/GitSettings.kt b/app/src/main/java/com/zeapo/pwdstore/git/config/GitSettings.kt index b0d931e0..1169345b 100644 --- a/app/src/main/java/com/zeapo/pwdstore/git/config/GitSettings.kt +++ b/app/src/main/java/com/zeapo/pwdstore/git/config/GitSettings.kt @@ -5,6 +5,8 @@ package com.zeapo.pwdstore.git.config import androidx.core.content.edit +import com.github.michaelbull.result.getOrElse +import com.github.michaelbull.result.runCatching import com.zeapo.pwdstore.Application import com.zeapo.pwdstore.utils.PasswordRepository import com.zeapo.pwdstore.utils.PreferenceKeys @@ -105,9 +107,9 @@ object GitSettings { } fun updateConnectionSettingsIfValid(newAuthMode: AuthMode, newUrl: String, newBranch: String): UpdateConnectionSettingsResult { - val parsedUrl = try { + val parsedUrl = runCatching { URIish(newUrl) - } catch (_: Exception) { + }.getOrElse { return UpdateConnectionSettingsResult.FailedToParseUrl } val newProtocol = when (parsedUrl.scheme) { -- cgit v1.2.3