From 0a71cc8aa53b6a7681208f5247bfd55d238ae19d Mon Sep 17 00:00:00 2001 From: Fabian Henneke Date: Tue, 3 Nov 2020 17:40:31 +0100 Subject: Fix Autofill regression caused by empty dataset (#1184) --- .../com/zeapo/pwdstore/autofill/oreo/AutofillResponseBuilder.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'app/src/main/java') diff --git a/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/AutofillResponseBuilder.kt b/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/AutofillResponseBuilder.kt index 1bee8c05..4af3c605 100644 --- a/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/AutofillResponseBuilder.kt +++ b/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/AutofillResponseBuilder.kt @@ -62,14 +62,14 @@ class AutofillResponseBuilder(form: FillableForm) { } private fun makeMatchDataset(context: Context, file: File, imeSpec: InlinePresentationSpec?): Dataset? { - if (scenario.hasFieldsToFillOn(AutofillAction.Match)) return null + if (!scenario.hasFieldsToFillOn(AutofillAction.Match)) return null val metadata = makeFillMatchMetadata(context, file) val intentSender = AutofillDecryptActivity.makeDecryptFileIntentSender(file, context) return makeIntentDataset(context, AutofillAction.Match, intentSender, metadata, imeSpec) } private fun makeSearchDataset(context: Context, imeSpec: InlinePresentationSpec?): Dataset? { - if (scenario.hasFieldsToFillOn(AutofillAction.Search)) return null + if (!scenario.hasFieldsToFillOn(AutofillAction.Search)) return null val metadata = makeSearchAndFillMetadata(context) val intentSender = AutofillFilterView.makeMatchAndDecryptFileIntentSender(context, formOrigin) @@ -77,14 +77,14 @@ class AutofillResponseBuilder(form: FillableForm) { } private fun makeGenerateDataset(context: Context, imeSpec: InlinePresentationSpec?): Dataset? { - if (scenario.hasFieldsToFillOn(AutofillAction.Generate)) return null + if (!scenario.hasFieldsToFillOn(AutofillAction.Generate)) return null val metadata = makeGenerateAndFillMetadata(context) val intentSender = AutofillSaveActivity.makeSaveIntentSender(context, null, formOrigin) return makeIntentDataset(context, AutofillAction.Generate, intentSender, metadata, imeSpec) } private fun makeFillOtpFromSmsDataset(context: Context, imeSpec: InlinePresentationSpec?): Dataset? { - if (scenario.hasFieldsToFillOn(AutofillAction.FillOtpFromSms)) return null + if (!scenario.hasFieldsToFillOn(AutofillAction.FillOtpFromSms)) return null if (!AutofillSmsActivity.shouldOfferFillFromSms(context)) return null val metadata = makeFillOtpFromSmsMetadata(context) val intentSender = AutofillSmsActivity.makeFillOtpFromSmsIntentSender(context) -- cgit v1.2.3