From f0ac9f97e2551aef14cd023de95da3281f12a5ee Mon Sep 17 00:00:00 2001
From: Harsh Shandilya <me@msfjarvis.dev>
Date: Thu, 27 Apr 2023 14:42:11 +0530
Subject: feat(build): remove Detekt

This no longer adds value for me and instead results in unnecessary
bikeshedding.
---
 build-logic/build.gradle.kts                          |  1 -
 .../app/passwordstore/gradle/KotlinCommonPlugin.kt    | 19 -------------------
 2 files changed, 20 deletions(-)

(limited to 'build-logic')

diff --git a/build-logic/build.gradle.kts b/build-logic/build.gradle.kts
index 41ee7256..5d7ab383 100644
--- a/build-logic/build.gradle.kts
+++ b/build-logic/build.gradle.kts
@@ -91,7 +91,6 @@ gradlePlugin {
 dependencies {
   implementation(platform(libs.kotlin.bom))
   implementation(libs.build.agp)
-  implementation(libs.build.detekt)
   implementation(libs.build.diffutils)
   implementation(libs.build.download)
   implementation(libs.build.kotlin)
diff --git a/build-logic/src/main/kotlin/app/passwordstore/gradle/KotlinCommonPlugin.kt b/build-logic/src/main/kotlin/app/passwordstore/gradle/KotlinCommonPlugin.kt
index 6d43a494..54907b1c 100644
--- a/build-logic/src/main/kotlin/app/passwordstore/gradle/KotlinCommonPlugin.kt
+++ b/build-logic/src/main/kotlin/app/passwordstore/gradle/KotlinCommonPlugin.kt
@@ -5,17 +5,13 @@
 
 package app.passwordstore.gradle
 
-import io.gitlab.arturbosch.detekt.DetektPlugin
-import io.gitlab.arturbosch.detekt.extensions.DetektExtension
 import org.gradle.api.JavaVersion
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.api.tasks.compile.JavaCompile
 import org.gradle.api.tasks.testing.Test
 import org.gradle.api.tasks.testing.logging.TestLogEvent
-import org.gradle.kotlin.dsl.configure
 import org.gradle.kotlin.dsl.withType
-import org.gradle.language.base.plugins.LifecycleBasePlugin
 import org.jetbrains.kotlin.gradle.dsl.JvmTarget
 import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
 import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
@@ -25,22 +21,7 @@ class KotlinCommonPlugin : Plugin<Project> {
 
   override fun apply(project: Project) {
     val isAppModule = project.pluginManager.hasPlugin("com.android.application")
-    project.pluginManager.apply(DetektPlugin::class.java)
-    project.extensions.configure<DetektExtension> {
-      parallel = true
-      ignoredBuildTypes = listOf("release")
-      ignoredFlavors = listOf("free")
-      basePath = project.layout.projectDirectory.toString()
-      baseline =
-        project.rootProject.layout.projectDirectory
-          .dir("detekt-baselines")
-          .file("${project.name}.xml")
-          .asFile
-    }
     project.tasks.run {
-      project.pluginManager.withPlugin("base") {
-        named(LifecycleBasePlugin.CHECK_TASK_NAME).configure { this.dependsOn(named("detekt")) }
-      }
       withType<JavaCompile>().configureEach {
         sourceCompatibility = JavaVersion.VERSION_11.toString()
         targetCompatibility = JavaVersion.VERSION_11.toString()
-- 
cgit v1.2.3