aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFabian Meumertzheim <fabian@meumertzhe.im>2021-03-04 08:10:21 +0100
committerHarsh Shandilya <me@msfjarvis.dev>2021-03-06 13:46:43 +0530
commitcdc198dec2d8febef7452b84c357ba247359fe91 (patch)
tree5eb1774150bb457c434318c5bfd7b0e0ae6e9fb6
parenteff07d177020a755da9eb7a313a2ea57591e684a (diff)
Mark Chrome as reliably fillable and saveable (#1338)
* Mark Chrome as reliably fillable and saveable * Mention Autofill improvements in CHANGELOG (cherry picked from commit 6206850eb298f554b7ce9a1cd9adb6a392ff1e54)
-rw-r--r--CHANGELOG.md1
-rw-r--r--autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt2
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9ece3189..aad8a194 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.
### Fixed
+- Autofill now works much more reliably in Chrome 89 and later, including support for saving passwords if no accessibility service is enabled.
- Editing a password allowed accidentally overwriting an existing one
diff --git a/autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt b/autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt
index 6c8d16e7..4df13213 100644
--- a/autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt
+++ b/autofill-parser/src/main/java/com/github/androidpasswordstore/autofillparser/FeatureAndTrustDetection.kt
@@ -146,6 +146,7 @@ private val BROWSER_SAVE_FLAG = mapOf(
@RequiresApi(Build.VERSION_CODES.O)
private val BROWSER_SAVE_FLAG_IF_NO_ACCESSIBILITY = mapOf(
+ "com.android.chrome" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE,
"com.chrome.beta" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE,
"com.chrome.canary" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE,
"com.chrome.dev" to SaveInfo.FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE,
@@ -181,7 +182,6 @@ fun getBrowserAutofillSupportInfoIfTrusted(
}
private val FLAKY_BROWSERS = listOf(
- "com.android.chrome",
"org.bromite.bromite",
"org.ungoogled.chromium.stable",
"com.kiwibrowser.browser",