aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHarsh Shandilya <me@msfjarvis.dev>2021-04-25 14:47:40 +0530
committerGitHub <noreply@github.com>2021-04-25 09:17:40 +0000
commitd3bc28c1c38e51a642331973b10edfb49ec026b3 (patch)
treecb6bdb855c882996fe6b969acaab4d6b83bb90eb
parent77d1a616dee2608d48e0dc6eaf925e5e2bc03681 (diff)
Do not ASCII armor files when encrypting (#1396)
-rw-r--r--CHANGELOG.md1
-rw-r--r--app/src/main/java/dev/msfjarvis/aps/ui/crypto/PasswordCreationActivity.kt2
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6a20482b..8e58de6a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -27,6 +27,7 @@ All notable changes to this project will be documented in this file.
- Accessibility autofill has been removed completely due to being buggy, insecure and lacking in features. Upgrade to Android 8 or preferably later to gain access to our advanced Autofill implementation.
- The settings UI has been completely re-done to dramatically improve discoverability and navigation for users
- Using the `git://` protocol in the server URL now presents an explicit discouragement rather than a generic error
+- Encrypted data is no longer ASCII armored, bringing it in line with `pass`
## [1.13.4] - 2021-03-20
diff --git a/app/src/main/java/dev/msfjarvis/aps/ui/crypto/PasswordCreationActivity.kt b/app/src/main/java/dev/msfjarvis/aps/ui/crypto/PasswordCreationActivity.kt
index 462dc388..23409460 100644
--- a/app/src/main/java/dev/msfjarvis/aps/ui/crypto/PasswordCreationActivity.kt
+++ b/app/src/main/java/dev/msfjarvis/aps/ui/crypto/PasswordCreationActivity.kt
@@ -366,7 +366,7 @@ class PasswordCreationActivity : BasePgpActivity(), OpenPgpServiceConnection.OnB
encryptionIntent.putExtra(OpenPgpApi.EXTRA_USER_IDS, userIds)
}
- encryptionIntent.putExtra(OpenPgpApi.EXTRA_REQUEST_ASCII_ARMOR, true)
+ encryptionIntent.putExtra(OpenPgpApi.EXTRA_REQUEST_ASCII_ARMOR, false)
val content = "$editPass\n$editExtra"
val inputStream = ByteArrayInputStream(content.toByteArray())