summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFabian Henneke <FabianHenneke@users.noreply.github.com>2020-08-27 11:51:15 +0200
committerGitHub <noreply@github.com>2020-08-27 15:21:15 +0530
commit1093928d93c097c92934cbb02a0f91f3f3845e3e (patch)
tree445f82b1d3be666738eede69d72a7c98c4b1b1bf
parent1ce3ef4ea3c55d4a6c4a79f8a6cca58387b240df (diff)
Delete HTTPS instead of SSH key password on error (#1060)
-rw-r--r--CHANGELOG.md1
-rw-r--r--app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt2
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index cc7e4a73..edeb3388 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@ All notable changes to this project will be documented in this file.
- Password creation UI will scroll if it does not fit on the screen
- Git server protocol and authentication mode are only updated when explicitly saved
+- Delete stored HTTPS password on connection errors (such as failed authentication)
## [1.11.2] - 2020-08-24
diff --git a/app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt b/app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt
index d537ba7f..eceb2b50 100644
--- a/app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt
+++ b/app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt
@@ -151,7 +151,7 @@ abstract class GitOperation(gitDir: File, internal val callingActivity: Fragment
open fun onError(err: Exception) {
// Clear various auth related fields on failure
callingActivity.getEncryptedPrefs("git_operation").edit {
- remove(PreferenceKeys.SSH_KEY_LOCAL_PASSPHRASE)
+ remove(PreferenceKeys.HTTPS_PASSWORD)
}
callingActivity.sharedPrefs.edit { remove(PreferenceKeys.SSH_OPENKEYSTORE_KEYID) }
d(err)