aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHarsh Shandilya <me@msfjarvis.dev>2023-04-27 01:37:20 +0530
committerHarsh Shandilya <me@msfjarvis.dev>2023-04-27 01:37:20 +0530
commit53497c03654cc04da40f7385c4d7711faa40e8f3 (patch)
tree12242945d362e6b13378b83a0db46e2eb15845c6
parentca327555cd71ff85e465a97898f6e7fa034d5a45 (diff)
feat(lint): update baselines
-rw-r--r--app/lint-baseline.xml151
-rw-r--r--autofill-parser/lint-baseline.xml2
-rw-r--r--coroutine-utils-testing/lint-baseline.xml4
-rw-r--r--coroutine-utils/lint-baseline.xml4
-rw-r--r--crypto-common/lint-baseline.xml4
-rw-r--r--crypto-pgpainless/lint-baseline.xml4
-rw-r--r--format-common/lint-baseline.xml4
-rw-r--r--passgen/diceware/lint-baseline.xml9
-rw-r--r--passgen/random/lint-baseline.xml15
-rw-r--r--sentry-stub/lint-baseline.xml4
-rw-r--r--ssh/lint-baseline.xml2
-rw-r--r--ui-compose/lint-baseline.xml13
12 files changed, 193 insertions, 23 deletions
diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml
index fb51ec01..e0ce6073 100644
--- a/app/lint-baseline.xml
+++ b/app/lint-baseline.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.4.2" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.2)" variant="all" version="7.4.2">
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
<issue
id="UnknownIssueId"
@@ -12,4 +12,153 @@
column="3"/>
</issue>
+ <issue
+ id="StopShip"
+ message="`TODO` call found; points to code which must be fixed prior to release"
+ errorLine1=" is Err -> TODO()"
+ errorLine2=" ~~~~~~">
+ <location
+ file="src/main/java/app/passwordstore/util/viewmodel/PGPKeyListViewModel.kt"
+ line="35"
+ column="19"/>
+ </issue>
+
+ <issue
+ id="InvalidPackage"
+ message="Invalid package reference in org.bouncycastle:bcpkix-jdk15to18; not included in Android: `javax.naming.directory`. Referenced from `org.bouncycastle.cert.dane.fetcher.JndiDANEFetcherFactory`.">
+ <location
+ file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.bouncycastle/bcpkix-jdk15to18/1.73/7673fe0f3510e88232c4bd98d027e9e0a3d0af6d/bcpkix-jdk15to18-1.73.jar"/>
+ </issue>
+
+ <issue
+ id="InvalidPackage"
+ message="Invalid package reference in org.bouncycastle:bcpkix-jdk15to18; not included in Android: `javax.naming`. Referenced from `org.bouncycastle.cert.dane.fetcher.JndiDANEFetcherFactory.1`.">
+ <location
+ file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.bouncycastle/bcpkix-jdk15to18/1.73/7673fe0f3510e88232c4bd98d027e9e0a3d0af6d/bcpkix-jdk15to18-1.73.jar"/>
+ </issue>
+
+ <issue
+ id="ConvertToWebp"
+ message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
+ <location
+ file="src/debug/res/mipmap-xxxhdpi/ic_launcher.png"/>
+ </issue>
+
+ <issue
+ id="ConvertToWebp"
+ message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
+ <location
+ file="src/main/res/mipmap-xxxhdpi/ic_launcher.png"/>
+ </issue>
+
+ <issue
+ id="SelectableText"
+ message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
+ errorLine1=" &lt;TextView"
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/res/layout/activity_oreo_autofill_filter.xml"
+ line="27"
+ column="4"/>
+ </issue>
+
+ <issue
+ id="SelectableText"
+ message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
+ errorLine1=" &lt;TextView"
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/res/layout/activity_oreo_autofill_publisher_changed.xml"
+ line="66"
+ column="4"/>
+ </issue>
+
+ <issue
+ id="SelectableText"
+ message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
+ errorLine1=" &lt;TextView"
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/res/layout/activity_oreo_autofill_publisher_changed.xml"
+ line="81"
+ column="4"/>
+ </issue>
+
+ <issue
+ id="SelectableText"
+ message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
+ errorLine1=" &lt;TextView"
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/res/layout/oreo_autofill_dataset.xml"
+ line="37"
+ column="6"/>
+ </issue>
+
+ <issue
+ id="SelectableText"
+ message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
+ errorLine1=" &lt;TextView"
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/res/layout/oreo_autofill_dataset.xml"
+ line="46"
+ column="6"/>
+ </issue>
+
+ <issue
+ id="SelectableText"
+ message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
+ errorLine1=" &lt;TextView"
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/res/layout/oreo_autofill_filter_row.xml"
+ line="29"
+ column="4"/>
+ </issue>
+
+ <issue
+ id="SelectableText"
+ message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
+ errorLine1=" &lt;TextView"
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/res/layout/oreo_autofill_filter_row.xml"
+ line="43"
+ column="4"/>
+ </issue>
+
+ <issue
+ id="UnknownNullness"
+ message="Should explicitly declare type here since implicit type does not specify nullness (Lazy&lt;Array&lt;(GitCommand&lt;out (Any or Any?)> or GitCommand&lt;out (Any or Any?)>?)>>)"
+ errorLine1=" override val commands by unsafeLazy {"
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/java/app/passwordstore/util/git/operation/BreakOutOfDetached.kt"
+ line="33"
+ column="16"/>
+ </issue>
+
+ <issue
+ id="UnknownNullness"
+ message="Should explicitly declare type here since implicit type does not specify nullness (Array&lt;(GitCommand&lt;out (Any or Any?)> or GitCommand&lt;out (Any or Any?)>?)>)"
+ errorLine1=" override val commands ="
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/java/app/passwordstore/util/git/operation/ResetToRemoteOperation.kt"
+ line="14"
+ column="16"/>
+ </issue>
+
+ <issue
+ id="UnknownNullness"
+ message="Should explicitly declare type here since implicit type does not specify nullness (Array&lt;(GitCommand&lt;out (Any or Any?)> or GitCommand&lt;out (Any or Any?)>?)>)"
+ errorLine1=" override val commands ="
+ errorLine2=" ~~~~~~~~">
+ <location
+ file="src/main/java/app/passwordstore/util/git/operation/SyncOperation.kt"
+ line="14"
+ column="16"/>
+ </issue>
+
</issues>
diff --git a/autofill-parser/lint-baseline.xml b/autofill-parser/lint-baseline.xml
index 0722790e..752ac952 100644
--- a/autofill-parser/lint-baseline.xml
+++ b/autofill-parser/lint-baseline.xml
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.4.2" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.2)" variant="all" version="7.4.2">
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
</issues>
diff --git a/coroutine-utils-testing/lint-baseline.xml b/coroutine-utils-testing/lint-baseline.xml
new file mode 100644
index 00000000..752ac952
--- /dev/null
+++ b/coroutine-utils-testing/lint-baseline.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
+
+</issues>
diff --git a/coroutine-utils/lint-baseline.xml b/coroutine-utils/lint-baseline.xml
new file mode 100644
index 00000000..752ac952
--- /dev/null
+++ b/coroutine-utils/lint-baseline.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
+
+</issues>
diff --git a/crypto-common/lint-baseline.xml b/crypto-common/lint-baseline.xml
new file mode 100644
index 00000000..752ac952
--- /dev/null
+++ b/crypto-common/lint-baseline.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
+
+</issues>
diff --git a/crypto-pgpainless/lint-baseline.xml b/crypto-pgpainless/lint-baseline.xml
new file mode 100644
index 00000000..752ac952
--- /dev/null
+++ b/crypto-pgpainless/lint-baseline.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
+
+</issues>
diff --git a/format-common/lint-baseline.xml b/format-common/lint-baseline.xml
new file mode 100644
index 00000000..752ac952
--- /dev/null
+++ b/format-common/lint-baseline.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
+
+</issues>
diff --git a/passgen/diceware/lint-baseline.xml b/passgen/diceware/lint-baseline.xml
index ec691a93..752ac952 100644
--- a/passgen/diceware/lint-baseline.xml
+++ b/passgen/diceware/lint-baseline.xml
@@ -1,11 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.4.2" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.2)" variant="all" version="7.4.2">
-
- <issue
- id="UnusedResources"
- message="The resource `R.raw.diceware_wordlist` appears to be unused">
- <location
- file="src/main/res/raw/diceware_wordlist.txt"/>
- </issue>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
</issues>
diff --git a/passgen/random/lint-baseline.xml b/passgen/random/lint-baseline.xml
new file mode 100644
index 00000000..02aa21bf
--- /dev/null
+++ b/passgen/random/lint-baseline.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
+
+ <issue
+ id="TrulyRandom"
+ message="Potentially insecure random numbers on Android 4.3 and older. Read https://android-developers.blogspot.com/2013/08/some-securerandom-thoughts.html for more info."
+ errorLine1="private val secureRandom = SecureRandom()"
+ errorLine2=" ~~~~~~~~~~~~">
+ <location
+ file="src/main/kotlin/app/passwordstore/passgen/random/RandomNumberGenerator.kt"
+ line="9"
+ column="28"/>
+ </issue>
+
+</issues>
diff --git a/sentry-stub/lint-baseline.xml b/sentry-stub/lint-baseline.xml
new file mode 100644
index 00000000..752ac952
--- /dev/null
+++ b/sentry-stub/lint-baseline.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
+
+</issues>
diff --git a/ssh/lint-baseline.xml b/ssh/lint-baseline.xml
index 0722790e..752ac952 100644
--- a/ssh/lint-baseline.xml
+++ b/ssh/lint-baseline.xml
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.4.2" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.2)" variant="all" version="7.4.2">
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
</issues>
diff --git a/ui-compose/lint-baseline.xml b/ui-compose/lint-baseline.xml
index 8a8d36be..752ac952 100644
--- a/ui-compose/lint-baseline.xml
+++ b/ui-compose/lint-baseline.xml
@@ -1,15 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
-<issues format="6" by="lint 7.4.2" type="baseline" client="gradle" dependencies="false" name="AGP (7.4.2)" variant="all" version="7.4.2">
-
- <issue
- id="UnusedResources"
- message="The resource `R.font.manrope` appears to be unused"
- errorLine1="&lt;font-family xmlns:app=&quot;http://schemas.android.com/apk/res-auto&quot;>"
- errorLine2="^">
- <location
- file="src/main/res/font/manrope.xml"
- line="6"
- column="1"/>
- </issue>
+<issues format="6" by="lint 8.0.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.0)" variant="all" version="8.0.0">
</issues>