diff options
| author | Fabian Henneke <FabianHenneke@users.noreply.github.com> | 2020-07-30 10:29:01 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-07-30 13:59:01 +0530 |
| commit | 3afeff45d8bd5fff66e1d0fa2c15fa2527487af1 (patch) | |
| tree | 7aef187653ee2b8dd4a8606cbffe708e03b7e409 /CHANGELOG.md | |
| parent | 8481491994f51127aa04aebcd26904ad904d6a77 (diff) | |
Fix two SMS Autofill crashes (#985)
SMS OTP Autofill currently crashes for two reasons:
1. Tasks.await has a precondition of not running on the UI thread.
2. Exceptions thrown from Tasks are always wrapped into
ExecutionExceptions and need to be unwrapped before they can be
identified as ResolvableApiException.
This commit addresses both issues by making waitForSms a proper
coroutine using withContext and a custom wrapper around Task<T> that
relies on suspendCoroutine and automatically unwraps exceptions.
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index a43462eb..f49f0cb0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file. - Allow creating nested directories directly - I keep saying this but for real: error message for wrong SSH/HTTPS password is properly fixed now - Correctly hide TOTP import button when TOTP secret/OTPAUTH URL is already present in extra content +- SMS OTP Autofill no longer crashes when invoked and correctly asks for the required permission on first use ## [1.10.1] - 2020-07-23 |