diff options
| author | Fabian Henneke <FabianHenneke@users.noreply.github.com> | 2020-07-30 10:29:01 +0200 |
|---|---|---|
| committer | Harsh Shandilya <me@msfjarvis.dev> | 2020-07-30 14:00:33 +0530 |
| commit | 23158ce6da8332bdb1f75a589b31ebcd1d819e00 (patch) | |
| tree | f5ca80b563eaf075546feb92edb2109a8e85ece0 /CHANGELOG.md | |
| parent | c132cc98e632036731b118d886709d783a55cc71 (diff) | |
Fix two SMS Autofill crashes (#985)
SMS OTP Autofill currently crashes for two reasons:
1. Tasks.await has a precondition of not running on the UI thread.
2. Exceptions thrown from Tasks are always wrapped into
ExecutionExceptions and need to be unwrapped before they can be
identified as ResolvableApiException.
This commit addresses both issues by making waitForSms a proper
coroutine using withContext and a custom wrapper around Task<T> that
relies on suspendCoroutine and automatically unwraps exceptions.
(cherry picked from commit 3afeff45d8bd5fff66e1d0fa2c15fa2527487af1)
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c79702e..38eb7eb0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file. - Properly handle cases where files contain only TOTP secrets and no password - Correctly hide TOTP import button when TOTP secret/OTPAUTH URL is already present in extra content +- SMS OTP Autofill no longer crashes when invoked and correctly asks for the required permission on first use ## [1.10.1] - 2020-07-23 |