Fix lint warnings (#319)

* Fix lint errors/warnings

Fix a lot of lint errors and warnings.
Most things are automatically applied fixes done with android studio:

* externalize strings
* remove unused code / classes / layouts / imports
* migrate some fields to local variables

* Remove dead code from comments

Removed code that is commented out long ago.

* remove unused resources

* colors
* strings
* drawables
* layouts
* menus

2 files changed, 1 insertions, 8 deletions

diff --git a/app/src/androidTest/java/com/zeapo/pwdstore/GitActivityClone.java b/app/src/androidTest/java/com/zeapo/pwdstore/GitActivityClone.java
index 80a915f8..dccb4eb8 100644
--- a/app/src/androidTest/java/com/zeapo/pwdstore/GitActivityClone.java
+++ b/app/src/androidTest/java/com/zeapo/pwdstore/GitActivityClone.java
@@ -6,12 +6,9 @@ import android.content.Intent;
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;
 import android.test.ActivityInstrumentationTestCase2;
-import android.util.Log;
-import android.widget.Button;
 import android.widget.EditText;
 import android.widget.Spinner;
 
-import com.robotium.solo.Solo;
 import com.zeapo.pwdstore.git.GitActivity;
 import com.zeapo.pwdstore.utils.PasswordRepository;
 
@@ -20,7 +17,6 @@ import org.apache.commons.io.FileUtils;
 import java.io.File;
 
 public class GitActivityClone extends ActivityInstrumentationTestCase2<GitActivity> {
-    private static final String TAG = "GitActTest";
     private Activity gitActivity;
     private Instrumentation mInstrumentation;
     private SharedPreferences settings;
@@ -71,7 +67,7 @@ public class GitActivityClone extends ActivityInstrumentationTestCase2<GitActivi
     }
 
     public void testCloneSshUser() throws Exception {
-        final Solo solo = new Solo(getInstrumentation(), getActivity());
+        // final Solo solo = new Solo(getInstrumentation(), getActivity());
         FileUtils.deleteDirectory(new File(gitActivity.getFilesDir() +  gitActivity.getResources().getString(R.string.store_git)));
         // create the repository static variable in PasswordRepository
         PasswordRepository.getRepository(new File(gitActivity.getFilesDir() + gitActivity.getResources().getString(R.string.store_git)));
diff --git a/app/src/androidTest/java/com/zeapo/pwdstore/GitActivityTest.java b/app/src/androidTest/java/com/zeapo/pwdstore/GitActivityTest.java
index 83995b51..6073c211 100644
--- a/app/src/androidTest/java/com/zeapo/pwdstore/GitActivityTest.java
+++ b/app/src/androidTest/java/com/zeapo/pwdstore/GitActivityTest.java
@@ -6,9 +6,6 @@ import android.content.Intent;
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;
 import android.test.ActivityInstrumentationTestCase2;
-import android.test.ActivityTestCase;
-import android.test.InstrumentationTestCase;
-import android.util.Log;
 import android.widget.EditText;
 import android.widget.Spinner;