diff options
| author | Fabian Henneke <FabianHenneke@users.noreply.github.com> | 2020-03-27 09:58:41 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-27 09:58:41 +0100 |
| commit | 791868f3d6a871379b766e44fb41755d794eb36e (patch) | |
| tree | 1707b8525a0a0b281ec2362ffee452ad39a3e953 /app/src/main/java | |
| parent | 0153d3215ea5f3afa5076b4b5f51f98cc2482a47 (diff) | |
Fix: Set childCount correctly on recycled rows (#675)
The childCount is not set explicitly for empty directories, which means
that the childCount of the entry from which the current row was
recycled is preserved. This results in empty directories being shown
with seemingly random child counts.
The fix is to always set text and visibility for the childCount view.
Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
Diffstat (limited to 'app/src/main/java')
| -rw-r--r-- | app/src/main/java/com/zeapo/pwdstore/ui/adapters/EntryRecyclerAdapter.kt | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/app/src/main/java/com/zeapo/pwdstore/ui/adapters/EntryRecyclerAdapter.kt b/app/src/main/java/com/zeapo/pwdstore/ui/adapters/EntryRecyclerAdapter.kt index fc9c84bc..9cf477e2 100644 --- a/app/src/main/java/com/zeapo/pwdstore/ui/adapters/EntryRecyclerAdapter.kt +++ b/app/src/main/java/com/zeapo/pwdstore/ui/adapters/EntryRecyclerAdapter.kt @@ -99,10 +99,8 @@ abstract class EntryRecyclerAdapter internal constructor(val values: ArrayList<P !(!showHidden && (pathname.isDirectory && pathname.isHidden)) } ?: emptyArray<File>() val childCount = children.size - if (childCount > 0) { - holder.childCount.visibility = View.VISIBLE - holder.childCount.text = "$childCount" - } + holder.childCount.visibility = if (childCount > 0) View.VISIBLE else View.GONE + holder.childCount.text = "$childCount" } else { holder.typeImage.setImageResource(R.drawable.ic_action_secure_24dp) val parentPath = pass.fullPathToParent.replace("(^/)|(/$)".toRegex(), "") |