summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
authorHarsh Shandilya <me@msfjarvis.dev>2022-04-24 16:24:46 +0530
committerHarsh Shandilya <me@msfjarvis.dev>2022-04-24 16:47:51 +0530
commit4775d4429283b2d49905d7dc080c19e5302f7fd7 (patch)
treeb402ea322d82d554bc83863456ce4ac17d956e18 /app
parentecba50cbae1a01a3436c4803fcc1429333a0fbb4 (diff)
app: address Overdraw lint
Diffstat (limited to 'app')
-rw-r--r--app/lint-baseline.xml44
-rw-r--r--app/src/main/res/layout/activity_git_clone.xml2
-rw-r--r--app/src/main/res/layout/fragment_clone.xml3
-rw-r--r--app/src/main/res/layout/fragment_key_selection.xml1
-rw-r--r--app/src/main/res/layout/fragment_welcome.xml1
5 files changed, 1 insertions, 50 deletions
diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml
index 4b312c7a..083124c3 100644
--- a/app/lint-baseline.xml
+++ b/app/lint-baseline.xml
@@ -24,50 +24,6 @@
</issue>
<issue
- id="Overdraw"
- message="Possible overdraw: Root element paints background `?android:attr/windowBackground` with a theme that also paints a background (inferred theme is `@style/AppThemeM3`)"
- errorLine1=" android:background=&quot;?android:attr/windowBackground&quot;"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/main/res/layout/activity_git_clone.xml"
- line="11"
- column="3"/>
- </issue>
-
- <issue
- id="Overdraw"
- message="Possible overdraw: Root element paints background `?android:attr/colorBackground` with a theme that also paints a background (inferred theme is `@style/AppThemeM3`)"
- errorLine1=" android:background=&quot;?android:attr/colorBackground&quot;>"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/main/res/layout/fragment_clone.xml"
- line="10"
- column="3"/>
- </issue>
-
- <issue
- id="Overdraw"
- message="Possible overdraw: Root element paints background `?android:attr/colorBackground` with a theme that also paints a background (inferred theme is `@style/AppThemeM3`)"
- errorLine1=" android:background=&quot;?android:attr/colorBackground&quot;"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/main/res/layout/fragment_key_selection.xml"
- line="10"
- column="3"/>
- </issue>
-
- <issue
- id="Overdraw"
- message="Possible overdraw: Root element paints background `?android:attr/colorBackground` with a theme that also paints a background (inferred theme is `@style/AppThemeM3`)"
- errorLine1=" android:background=&quot;?android:attr/colorBackground&quot;"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="src/main/res/layout/fragment_welcome.xml"
- line="10"
- column="3"/>
- </issue>
-
- <issue
id="Autofill"
message="Missing `autofillHints` attribute"
errorLine1=" &lt;EditText"
diff --git a/app/src/main/res/layout/activity_git_clone.xml b/app/src/main/res/layout/activity_git_clone.xml
index 6c991faa..7980f738 100644
--- a/app/src/main/res/layout/activity_git_clone.xml
+++ b/app/src/main/res/layout/activity_git_clone.xml
@@ -8,9 +8,7 @@
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
- android:background="?android:attr/windowBackground"
android:padding="@dimen/activity_horizontal_margin"
- tools:background="@color/white"
tools:context="dev.msfjarvis.aps.ui.git.config.GitServerConfigActivity">
<androidx.constraintlayout.widget.ConstraintLayout
diff --git a/app/src/main/res/layout/fragment_clone.xml b/app/src/main/res/layout/fragment_clone.xml
index cb2cc04e..f85cafac 100644
--- a/app/src/main/res/layout/fragment_clone.xml
+++ b/app/src/main/res/layout/fragment_clone.xml
@@ -6,8 +6,7 @@
<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
- android:layout_height="match_parent"
- android:background="?android:attr/colorBackground">
+ android:layout_height="match_parent">
<androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/fragment_key_selection.xml b/app/src/main/res/layout/fragment_key_selection.xml
index 937d8751..bc4f5367 100644
--- a/app/src/main/res/layout/fragment_key_selection.xml
+++ b/app/src/main/res/layout/fragment_key_selection.xml
@@ -7,7 +7,6 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="match_parent"
- android:background="?android:attr/colorBackground"
android:orientation="vertical">
<androidx.appcompat.widget.AppCompatImageView
diff --git a/app/src/main/res/layout/fragment_welcome.xml b/app/src/main/res/layout/fragment_welcome.xml
index 18e90082..0e71b88d 100644
--- a/app/src/main/res/layout/fragment_welcome.xml
+++ b/app/src/main/res/layout/fragment_welcome.xml
@@ -7,7 +7,6 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="match_parent"
- android:background="?android:attr/colorBackground"
android:orientation="vertical">
<com.google.android.material.button.MaterialButton