aboutsummaryrefslogtreecommitdiff
path: root/build-logic
diff options
context:
space:
mode:
authorHarsh Shandilya <me@msfjarvis.dev>2023-06-01 18:24:45 +0530
committerHarsh Shandilya <me@msfjarvis.dev>2023-06-04 01:52:57 +0530
commit53476f612b3cfef292717d18dd54ca82d9e0baa3 (patch)
tree74dbd19e35c3ea5fadb30bf04f2295391aed6f64 /build-logic
parent59dc6d27ded6f107655824747c021dedffd4f4b7 (diff)
feat: add `slack-lint-checks`
Diffstat (limited to 'build-logic')
-rw-r--r--build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt8
-rw-r--r--build-logic/src/main/kotlin/app/passwordstore/gradle/LintConfig.kt7
2 files changed, 11 insertions, 4 deletions
diff --git a/build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt b/build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt
index d73239c2..f3fe5a95 100644
--- a/build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt
+++ b/build-logic/src/main/kotlin/app/passwordstore/gradle/AndroidCommon.kt
@@ -47,11 +47,11 @@ object AndroidCommon {
}
project.extensions.findByType<ApplicationExtension>()?.run { lint.configureLint(project) }
project.extensions.findByType<LibraryExtension>()?.run { lint.configureLint(project) }
+ val lintDepKeys = listOf("thirdparty-compose-lints", "thirdparty-slack-lints")
val catalog = project.extensions.getByType<VersionCatalogsExtension>()
val libs = catalog.named("libs")
- project.dependencies.addProvider(
- "lintChecks",
- libs.findLibrary("thirdparty-compose-lints").get()
- )
+ lintDepKeys.forEach { key ->
+ project.dependencies.addProvider("lintChecks", libs.findLibrary(key).get())
+ }
}
}
diff --git a/build-logic/src/main/kotlin/app/passwordstore/gradle/LintConfig.kt b/build-logic/src/main/kotlin/app/passwordstore/gradle/LintConfig.kt
index de63c580..361b92cd 100644
--- a/build-logic/src/main/kotlin/app/passwordstore/gradle/LintConfig.kt
+++ b/build-logic/src/main/kotlin/app/passwordstore/gradle/LintConfig.kt
@@ -29,8 +29,15 @@ object LintConfig {
// False-positives abound due to use of ViewBinding
disable += "UnusedIds"
if (!isJVM) {
+ // Enable compose-lint-checks' Material 2 detector
enable += "ComposeM2Api"
error += "ComposeM2Api"
+ // slack-lint-checks' checker for deprecations is useless to me
+ disable += "DeprecatedCall"
+ // Hilt only does field injection for fragments
+ disable += "FragmentFieldInjection"
+ // Too pedantic
+ disable += "ArgInFormattedQuantityStringRes"
}
baseline = project.file("lint-baseline.xml")
}