Begin cleaning up Detekt warnings (#2027)

1 files changed, 0 insertions, 35 deletions

diff --git a/detekt-baselines/app.xml b/detekt-baselines/app.xml
index be37b720..a82c325e 100644
--- a/detekt-baselines/app.xml
+++ b/detekt-baselines/app.xml
@@ -35,59 +35,28 @@
     <ID>LongMethod:RepositorySettings.kt$RepositorySettings$override fun provideSettings(builder: PreferenceScreen.Builder)</ID>
     <ID>LoopWithTooManyJumpStatements:AutofillMatcher.kt$AutofillMatcher.Companion$for ((key, value) in prefs.all) { if (!key.startsWith(PREFERENCE_PREFIX_MATCHES)) continue // We know that preferences starting with `PREFERENCE_PREFIX_MATCHES` were // created with `putStringSet`. @Suppress("UNCHECKED_CAST") val oldMatches = value as? Set&lt;String> if (oldMatches == null) { logcat(WARN) { "Failed to read matches for $key" } continue } // Delete all matches for file locations that are going to be overwritten, then // transfer matches over to the files at their new locations. val newMatches = oldMatches .asSequence() .minus(deletePathList) .minus(oldNewPathMap.values) .map { match -> val newPath = oldNewPathMap[match] ?: return@map match logcat { "Updating match for $key: $match --> $newPath" } newPath } .toSet() if (newMatches != oldMatches) prefs.edit { putStringSet(key, newMatches) } }</ID>
     <ID>LoopWithTooManyJumpStatements:ErrorMessages.kt$ErrorMessages$while (cause.cause != null) { if (cause is GitException) break val nextCause = cause.cause!! if (nextCause is RemoteException) break cause = nextCause }</ID>
-    <ID>MagicNumber:Api30AutofillResponseBuilder.kt$Api30AutofillResponseBuilder$30</ID>
-    <ID>MagicNumber:AutofillDecryptActivity.kt$AutofillDecryptActivity$26</ID>
-    <ID>MagicNumber:AutofillDecryptActivity.kt$AutofillDecryptActivity.Companion$31</ID>
-    <ID>MagicNumber:AutofillFilterView.kt$AutofillFilterView$26</ID>
-    <ID>MagicNumber:AutofillFilterView.kt$AutofillFilterView.Companion$31</ID>
-    <ID>MagicNumber:AutofillPreferences.kt$DirectoryStructure$26</ID>
-    <ID>MagicNumber:AutofillPublisherChangedActivity.kt$AutofillPublisherChangedActivity$26</ID>
-    <ID>MagicNumber:AutofillPublisherChangedActivity.kt$AutofillPublisherChangedActivity.Companion$31</ID>
-    <ID>MagicNumber:AutofillResponseBuilder.kt$AutofillResponseBuilder$26</ID>
-    <ID>MagicNumber:AutofillResponseBuilder.kt$AutofillResponseBuilder$28</ID>
-    <ID>MagicNumber:AutofillResponseBuilder.kt$AutofillResponseBuilder.Companion$28</ID>
-    <ID>MagicNumber:AutofillSaveActivity.kt$AutofillSaveActivity$26</ID>
-    <ID>MagicNumber:AutofillSettings.kt$AutofillSettings$26</ID>
-    <ID>MagicNumber:AutofillViewUtils.kt$30</ID>
-    <ID>MagicNumber:AutofillViewUtils.kt$31</ID>
-    <ID>MagicNumber:BasePgpActivity.kt$BasePgpActivity$26</ID>
     <ID>MagicNumber:BasePgpActivity.kt$BasePgpActivity$45</ID>
     <ID>MagicNumber:ClipboardService.kt$ClipboardService$1000</ID>
     <ID>MagicNumber:ClipboardService.kt$ClipboardService$1000L</ID>
-    <ID>MagicNumber:ClipboardService.kt$ClipboardService$23</ID>
-    <ID>MagicNumber:ClipboardService.kt$ClipboardService$24</ID>
-    <ID>MagicNumber:ClipboardService.kt$ClipboardService$26</ID>
-    <ID>MagicNumber:ClipboardService.kt$ClipboardService$31</ID>
     <ID>MagicNumber:ClipboardService.kt$ClipboardService$45</ID>
     <ID>MagicNumber:ClipboardService.kt$ClipboardService$500</ID>
     <ID>MagicNumber:DicewareModule.kt$DicewareModule$6</ID>
     <ID>MagicNumber:DicewarePasswordGeneratorDialogFragment.kt$DicewarePasswordGeneratorDialogFragment$5</ID>
     <ID>MagicNumber:Extensions.kt$1000</ID>
-    <ID>MagicNumber:GeneralSettings.kt$GeneralSettings$25</ID>
     <ID>MagicNumber:GitConfigActivity.kt$GitConfigActivity$0.5f</ID>
     <ID>MagicNumber:GitConfigActivity.kt$GitConfigActivity$500</ID>
     <ID>MagicNumber:GitConfigActivity.kt$GitConfigActivity$8</ID>
     <ID>MagicNumber:GitLogAdapter.kt$8</ID>
     <ID>MagicNumber:GitServerConfigActivity.kt$GitServerConfigActivity$500</ID>
     <ID>MagicNumber:LaunchActivity.kt$LaunchActivity$500L</ID>
-    <ID>MagicNumber:OreoAutofillService.kt$OreoAutofillService$26</ID>
-    <ID>MagicNumber:OreoAutofillService.kt$OreoAutofillService$28</ID>
-    <ID>MagicNumber:OreoAutofillService.kt$OreoAutofillService$30</ID>
-    <ID>MagicNumber:PasswordCreationActivity.kt$PasswordCreationActivity$28</ID>
     <ID>MagicNumber:PasswordExportService.kt$PasswordExportService$1024</ID>
-    <ID>MagicNumber:PasswordExportService.kt$PasswordExportService$26</ID>
     <ID>MagicNumber:PasswordGeneratorDialogFragment.kt$PasswordGeneratorDialogFragment$20</ID>
     <ID>MagicNumber:PasswordItemRecyclerAdapter.kt$PasswordItemRecyclerAdapter.PasswordItemViewHolder$0.7f</ID>
-    <ID>MagicNumber:ProxySelectorActivity.kt$ProxySelectorActivity$29</ID>
     <ID>MagicNumber:ProxySelectorActivity.kt$ProxySelectorActivity$500</ID>
-    <ID>MagicNumber:RepositorySettings.kt$RepositorySettings$25</ID>
-    <ID>MagicNumber:ShortcutHandler.kt$ShortcutHandler$25</ID>
-    <ID>MagicNumber:ShortcutHandler.kt$ShortcutHandler$26</ID>
     <ID>MagicNumber:SshKey.kt$SshKey$100_000</ID>
     <ID>MagicNumber:SshKey.kt$SshKey$15</ID>
     <ID>MagicNumber:SshKey.kt$SshKey$30</ID>
     <ID>MagicNumber:SshKey.kt$SshKey.Algorithm.Ecdsa$256</ID>
-    <ID>MagicNumber:SshKey.kt$SshKey.Algorithm.Ecdsa$28</ID>
     <ID>MagicNumber:SshKey.kt$SshKey.Algorithm.Rsa$3072</ID>
     <ID>MagicNumber:SshjSessionFactory.kt$SshjSession$22</ID>
     <ID>MagicNumber:UriTotpFinder.kt$UriTotpFinder$30</ID>
@@ -124,9 +93,7 @@
     <ID>ThrowsCount:GitCommandExecutor.kt$GitCommandExecutor$suspend fun execute(): Result&lt;Unit, Throwable></ID>
     <ID>ThrowsCount:SshKey.kt$SshKey$fun import(uri: Uri)</ID>
     <ID>TooManyFunctions:PasswordStore.kt$PasswordStore : BaseGitActivity</ID>
-    <ID>TooManyFunctions:SearchableRepositoryViewModel.kt$SearchableRepositoryViewModel : AndroidViewModel</ID>
     <ID>TooManyFunctions:SshjConfig.kt$AbstractLogger : Logger</ID>
-    <ID>TooManyFunctions:SshjConfig.kt$LogcatLoggerFactory$LogcatLogger : AbstractLogger</ID>
     <ID>TopLevelPropertyNaming:AutofillMatcher.kt$private const val PREFERENCES_AUTOFILL_APP_MATCHES = "oreo_autofill_app_matches"</ID>
     <ID>TopLevelPropertyNaming:AutofillMatcher.kt$private const val PREFERENCES_AUTOFILL_WEB_MATCHES = "oreo_autofill_web_matches"</ID>
     <ID>TopLevelPropertyNaming:Extensions.kt$/** The default OpenPGP provider for the app */ const val OPENPGP_PROVIDER = "org.sufficientlysecure.keychain"</ID>
@@ -134,8 +101,6 @@
     <ID>TopLevelPropertyNaming:SshKey.kt$private const val ANDROIDX_SECURITY_KEYSET_PREF_NAME = "androidx_sshkey_keyset_prefs"</ID>
     <ID>TopLevelPropertyNaming:SshKey.kt$private const val KEYSTORE_ALIAS = "sshkey"</ID>
     <ID>TopLevelPropertyNaming:SshKey.kt$private const val PROVIDER_ANDROID_KEY_STORE = "AndroidKeyStore"</ID>
-    <ID>UnusedPrivateMember:PasswordStore.kt$PasswordStore$private val directorySelectAction = registerForActivityResult(StartActivityForResult()) { result -> if (result.resultCode == RESULT_OK) { checkLocalRepository() } }</ID>
-    <ID>UnusedPrivateMember:PasswordStore.kt$PasswordStore$private val storagePermissionRequest = registerForActivityResult(RequestPermission()) { granted -> if (granted) checkLocalRepository() }</ID>
     <ID>UseCheckOrError:CredentialFinder.kt$CredentialFinder$throw IllegalStateException("Only SshKey and Password connection mode ask for passwords")</ID>
     <ID>UseCheckOrError:FragmentViewBindingDelegate.kt$FragmentViewBindingDelegate$throw IllegalStateException( "Should not attempt to get bindings when Fragment views are destroyed." )</ID>
     <ID>UseCheckOrError:GitOperation.kt$GitOperation$throw IllegalStateException("Biometric authentication failures should be ignored")</ID>