summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-10-17Use BottomSheet in place of Snackbar for longer messages (#1157)ashoksinghal
2020-10-16Revamp build configuration (#1156)Harsh Shandilya
* release: move scripts to scripts directory Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Move CI secrets to secrets directory Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * gradle: uprev to 6.7 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * gradle: suppress warnings about unsupported options Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: update dependencies Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: move Gradle plugins to ext Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: move configuration tasks to buildSrc Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * CHANGELOG: add entry for #1137 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Fix lint warnings Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-15Add option to automatically sync repository on app launch (#1137)Aditya Wasan
* Add option to automatically sync repository on app launch Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Pull repo if user is not authenticated Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Hijack incoming intent rather than copying it Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Initialize password repository before using it Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13Merge branch 'release' into developHarsh Shandilya
* release: build: bump version CHANGELOG: add entries for #1142 and #1131 Temporarily work around SSHJ compatibility issues (#1142) all: refactor ActivityResultContracts usages to adhere to API requirements Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13build: bump versionv1.12.1Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13github: fix release draft workflow (#1152)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13CHANGELOG: add entries for #1142 and #1131Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-13Temporarily work around SSHJ compatibility issues (#1142)Fabian Henneke
Using ECDSA either as a key exchange or a host key algorithm fails with SSHJ 0.30.0 on Android, but should again become possible in 0.31.0. While we wait for the release, demote ECDSA in the list of key algorithms (as it should still be available for public key auth) and remove it from the list of key exchange algorithms. (cherry picked from commit 0d2788ab54b7898c88e8dc03d88323d70781a795)
2020-10-13all: refactor ActivityResultContracts usages to adhere to API requirementsHarsh Shandilya
The newest versions of AndroidX Activity and Fragments correctly enforce the requirement for all contracts to be registered at class init or before the lifecycle has reached `Lifecycle.State.STARTED`. To comply with these requirements, move all instances of `registerForActivityResult` being called at arbitrary points in the code to be done at class init. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit cf03c554785ee822be3408edcfb81fa4cf03d0e5)
2020-10-11ProxyUtils: correctly handle the 'no proxy' case (#1148)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10github: update release draft workflowHarsh Shandilya
Switch to $GITHUB_ENV since set-env has been deprecated Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10github: update PSL workflowHarsh Shandilya
- Use the pull request action utilized by GitHub for their own projects - Switch to $GITHUB_ENV since set-env has been deprecated Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10github: lay down some ground rules in issue templatesHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10res: merge unneeded override into base fileHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10release/deploy-github: removeHarsh Shandilya
Release artifacts are now delivered by CI Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10crowdin: remove unused config fileHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10gitmodules: remove empty fileHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10release/signing-setup: don't set -xHarsh Shandilya
This causes the secret to be printed to stdout which is undesirable, even with CI redacting it Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10CHANGELOG: add proxy entryHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10contrib: removeHarsh Shandilya
A more thorough and expansive import tool exists at https://github.com/roddhjav/pass-import that offers better UX than having to run a Haskell script Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10Update Public Suffix List data (#1145)github-actions[bot]
Co-authored-by: FabianHenneke <FabianHenneke@users.noreply.github.com>
2020-10-08Temporarily work around SSHJ compatibility issues (#1142)Fabian Henneke
Using ECDSA either as a key exchange or a host key algorithm fails with SSHJ 0.30.0 on Android, but should again become possible in 0.31.0. While we wait for the release, demote ECDSA in the list of key algorithms (as it should still be available for public key auth) and remove it from the list of key exchange algorithms.
2020-10-08Introduce app-wide HTTPS proxy setting (#1134)Harsh Shandilya
2020-10-08autofill-parser: flesh out generated POM file (#1140)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-07build: update runtime dependencies and Gradle plugins (#1139)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-06Show new FillResponse right after publisher reset (#1138)Fabian Henneke
If Autofill shows a warning about an app whose publisher changed and the user decides to trust the app and clear previous matches, they should immediately be given the option to select a new match. Previously, as AutofillPublisherChangedActivity did not return a result, the old FillResponse with just a warning would be reused. We now pass a useful response with no matches on to the activity, which returns it after the user has chosen to reset the publisher info.
2020-10-06Fix Autofill publisher changed layout (#1136)Harsh Shandilya
* Fix Autofill publisher changed layout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Tweak autofill publisher UI Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2020-10-05Resolve lock contention from lazy delegates (#1135)Harsh Shandilya
2020-10-03Update Public Suffix List data (#1132)github-actions[bot]
Co-authored-by: FabianHenneke <FabianHenneke@users.noreply.github.com>
2020-10-02github: switch PR workflow from an allowlist to a blocklistHarsh Shandilya
This is going to be less work to maintain going forward since we won't need to change it every time we include a new subproject. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02all: refactor ActivityResultContracts usages to adhere to API requirementsHarsh Shandilya
The newest versions of AndroidX Activity and Fragments correctly enforce the requirement for all contracts to be registered at class init or before the lifecycle has reached `Lifecycle.State.STARTED`. To comply with these requirements, move all instances of `registerForActivityResult` being called at arbitrary points in the code to be done at class init. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02build: uprev dependenciesHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02Allow matching password fields based on hints only (#1129)Fabian Henneke
Filling passwords is usually only offered for fields with a password input type, which ensures that they are always properly masked. Certain custom views (e.g., the Termux terminal view), may apply their own masking that is not based on the standard views. With this commit, we allow filling passwords into arbitrary fields as long as they have an Autofill hint that indicates a password.
2020-10-02Exit tie breakers early in unique or no match case (#1130)Fabian Henneke
Tie breakers for Autofill fields should only be evaluated if there is a need to, in particular not if only a single or no field is matched. Apart from a potential minor performance improvement, this should not cause any user-visible changes, but does simplify the log output considerably.
2020-10-01build: prepare next development versionHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01Add changelog entryHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01Add key selection step to onboarding flowHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01PasswordCreationActivity: tweak logic for determining if identifier ↵Harsh Shandilya
selection is needed Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01Make unset author/email behavior match GitHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01github: run apiCheck task in pull requestsHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01github: update workflows to use gradle-cache-actionHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01autofill-parser: check in API dumpHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01build: configure binary-compatibility-validatorHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-29Unwrap root cause for InvalidRemoteException (#1122)Harsh Shandilya
* BaseGitActivity: unwrap root cause for InvalidRemoteException as well JGit's InvalidRemoteException, like TransportException, swallows more useful errors as is clear from this (redacted) snippet. ``` D org.eclipse.jgit.api.errors.InvalidRemoteException: Invalid remote: origin D at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:26) D at org.eclipse.jgit.api.PullCommand.call(PullCommand.java:41) D at com.zeapo.pwdstore.git.GitCommandExecutor$execute$2$result$1.invokeSuspend(GitCommandExecutor.kt:2) D at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3) D at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:15) D at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:1) D at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:13) D Caused by: org.eclipse.jgit.errors.NoRemoteRepositoryException: ssh://msfjarvis@[fe80::dead:beef]:22/pass-repo: fatal: '/pass-repo' does not appear to be a git repository D at org.eclipse.jgit.transport.TransportGitSsh.cleanNotFound(TransportGitSsh.java:14) D at org.eclipse.jgit.transport.TransportGitSsh$SshFetchConnection.<init>(TransportGitSsh.java:20) D at org.eclipse.jgit.transport.TransportGitSsh.openFetch(TransportGitSsh.java:1) D at org.eclipse.jgit.transport.FetchProcess.executeImp(FetchProcess.java:1) D at org.eclipse.jgit.transport.Transport.fetch(Transport.java:20) D at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:18) ``` Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Add changelog entry Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-26Update Public Suffix List data (#1121)github-actions[bot]
Co-authored-by: FabianHenneke <FabianHenneke@users.noreply.github.com>
2020-09-24Prepare release 1.12.0v1.12.0Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-24Restore settings button to onboarding screen (#1119)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-22Sync strings from Crowdin (#1117)Harsh Shandilya
* strings: sync from Crowdin Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: disable ImpliedQuantity lint I hope our translators know better Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-21Remove Autofill onboarding prompt and cleanup strings (#1116)Harsh Shandilya
2020-09-21Refactor auth mode check/uncheck (#1115)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>