aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-10-02github: switch PR workflow from an allowlist to a blocklistHarsh Shandilya
This is going to be less work to maintain going forward since we won't need to change it every time we include a new subproject. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02all: refactor ActivityResultContracts usages to adhere to API requirementsHarsh Shandilya
The newest versions of AndroidX Activity and Fragments correctly enforce the requirement for all contracts to be registered at class init or before the lifecycle has reached `Lifecycle.State.STARTED`. To comply with these requirements, move all instances of `registerForActivityResult` being called at arbitrary points in the code to be done at class init. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02build: uprev dependenciesHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02Allow matching password fields based on hints only (#1129)Fabian Henneke
Filling passwords is usually only offered for fields with a password input type, which ensures that they are always properly masked. Certain custom views (e.g., the Termux terminal view), may apply their own masking that is not based on the standard views. With this commit, we allow filling passwords into arbitrary fields as long as they have an Autofill hint that indicates a password.
2020-10-02Exit tie breakers early in unique or no match case (#1130)Fabian Henneke
Tie breakers for Autofill fields should only be evaluated if there is a need to, in particular not if only a single or no field is matched. Apart from a potential minor performance improvement, this should not cause any user-visible changes, but does simplify the log output considerably.
2020-10-01build: prepare next development versionHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01Add changelog entryHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01Add key selection step to onboarding flowHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01PasswordCreationActivity: tweak logic for determining if identifier ↵Harsh Shandilya
selection is needed Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01Make unset author/email behavior match GitHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01github: run apiCheck task in pull requestsHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01github: update workflows to use gradle-cache-actionHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01autofill-parser: check in API dumpHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01build: configure binary-compatibility-validatorHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-29Unwrap root cause for InvalidRemoteException (#1122)Harsh Shandilya
* BaseGitActivity: unwrap root cause for InvalidRemoteException as well JGit's InvalidRemoteException, like TransportException, swallows more useful errors as is clear from this (redacted) snippet. ``` D org.eclipse.jgit.api.errors.InvalidRemoteException: Invalid remote: origin D at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:26) D at org.eclipse.jgit.api.PullCommand.call(PullCommand.java:41) D at com.zeapo.pwdstore.git.GitCommandExecutor$execute$2$result$1.invokeSuspend(GitCommandExecutor.kt:2) D at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3) D at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:15) D at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:1) D at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:13) D Caused by: org.eclipse.jgit.errors.NoRemoteRepositoryException: ssh://msfjarvis@[fe80::dead:beef]:22/pass-repo: fatal: '/pass-repo' does not appear to be a git repository D at org.eclipse.jgit.transport.TransportGitSsh.cleanNotFound(TransportGitSsh.java:14) D at org.eclipse.jgit.transport.TransportGitSsh$SshFetchConnection.<init>(TransportGitSsh.java:20) D at org.eclipse.jgit.transport.TransportGitSsh.openFetch(TransportGitSsh.java:1) D at org.eclipse.jgit.transport.FetchProcess.executeImp(FetchProcess.java:1) D at org.eclipse.jgit.transport.Transport.fetch(Transport.java:20) D at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:18) ``` Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Add changelog entry Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-26Update Public Suffix List data (#1121)github-actions[bot]
Co-authored-by: FabianHenneke <FabianHenneke@users.noreply.github.com>
2020-09-24Prepare release 1.12.0v1.12.0Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-24Restore settings button to onboarding screen (#1119)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-22Sync strings from Crowdin (#1117)Harsh Shandilya
* strings: sync from Crowdin Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: disable ImpliedQuantity lint I hope our translators know better Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-21Remove Autofill onboarding prompt and cleanup strings (#1116)Harsh Shandilya
2020-09-21Refactor auth mode check/uncheck (#1115)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-21Revert "github: remove ci-gradle.properties" (#1113)Harsh Shandilya
GitHub's runners are still too weak for us to go by without doing this: https://pipelines.actions.githubusercontent.com/eRaLlgv7QgiQrEiMWvOVzCfcXl8ehv3iNil9w7DRw7wdT9P1kT/_apis/pipelines/1/runs/2741/signedlogcontent/3?urlExpires=2020-09-21T07%3A46%3A57.1297541Z&urlSigningMethod=HMACV1&urlSignature=6e1r7tlUIn9E2EuEm2i4skqgQwZ4jCmO9ARlGZ6a3SU%3D This reverts commit 098c765132a823225e2b2ef82c1302e02f68cd31.
2020-09-20github: remove ci-gradle.propertiesHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20gradle: update properties list for build improvementsHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20Dependencies: downgrade annotation to 1.1.0Harsh Shandilya
We don't use the new annotation added in the alpha and since this dependency is shared between the library and app it's best to stick to stable until necessary Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20autofill-parser: add dependency on AndroidX annotationHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20autofill-parser: drop use of core-ktxHarsh Shandilya
We use an alpha version of core-ktx that might be undesirable for projects including the library Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20autofill-parser: add READMEHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20autofill-parser: configure maven-publish pluginHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19Add check for potential issues with SSH URLHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19BasicBottomSheet: initHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19Finish activity in case of external directory (#1110)Aditya Wasan
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-09-18Misc cleanups to build and extension functions (#1108)Harsh Shandilya
2020-09-18Add annotation to WelcomeFragment class (#1107)Aditya Wasan
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-09-17github: remove nonFree flavor from tests (#1102)Harsh Shandilya
Our tests have zero differences between these flavors so running 4 jobs rather than 2 just slows us down Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-16Autofill: Extract AutofillParser into separate subproject (#1101)Vincent Breitmoser
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-09-15Update on-boarding UI (#1099)Aditya Wasan
* Add onboarding flow from v2 Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Minor fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Add changelog entry Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Remove old activity from manifest Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Remove view type prefix from view ids Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Review fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Treewide: Reformat code Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Moar review fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Revert "Treewide: Reformat code" This reverts commit 348ef0050942526a55890b245afec8d7fee4d81e. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * onboarding: cleanup OnboardingActivity init Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unused layout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unnecessary ConstraintLayout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Shorten animation duration Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * onboarding: use viewBinding extension in fragments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-14Add tentative workaround for dialog crashes and refactor Git-related code ↵Harsh Shandilya
(#1100) * Ensure we're creating dialogs on the main thread Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unused operation type Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Refactor launchGitOperation to use an enum Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-13PasswordRepository: properly gate symlink feature (#1098)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-12Continue onboarding if permissions are granted prematurely (#1097)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-12Update Public Suffix List data (#1096)github-actions[bot]
Co-authored-by: FabianHenneke <FabianHenneke@users.noreply.github.com>
2020-09-11Correctly count children in password list (#1095)Harsh Shandilya
2020-09-11Disable SSH multiplexing if not supported (#1093)Fabian Henneke
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-10build: update Kotlin and dependency-updates plugin (#1094)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-10Autofill: add kiwi as a supported browser (#1091)Rounak Datta
2020-09-09Fix directory selection in onboarding if storage permissions are granted (#1090)Harsh Shandilya
* OnboardingActivity: fix directory change option Add an else clause to cover the case when storage permission is granted already Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * all: rename permission grant method The new name is a bit more explicit about its purpose Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * UserPreference: add static method for external directory selection intent Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-08Support multiple authentication methods (#825)Fabian Henneke
* Offer password SSH authentication after publickey * git: re-add back button handling Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Hide unsupported authentication methods Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * GitCommandExecutor: cleanup and address build warning Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * DecryptActivity: hide menu items until decrypt finishes Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Add changelog entry Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-08Use same checks as BiometricAuthenticator in UserPreference (#1088)Aditya Wasan
2020-09-07UX fixups and improvements (#1086)Harsh Shandilya
* git: re-add back button handling Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Hide unsupported authentication methods Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * GitCommandExecutor: cleanup and address build warning Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * DecryptActivity: hide menu items until decrypt finishes Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * GitServerConfigActivity: don't finish on failure Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-07Fix behavior on failing Git operations (#1084)Fabian Henneke
generated by cgit v1.2.3 (git 2.46.0) at 2024-11-27 14:31:09 +0000