aboutsummaryrefslogtreecommitdiff
path: root/app/src
AgeCommit message (Collapse)Author
2020-07-30Fix two SMS Autofill crashes (#985)Fabian Henneke
SMS OTP Autofill currently crashes for two reasons: 1. Tasks.await has a precondition of not running on the UI thread. 2. Exceptions thrown from Tasks are always wrapped into ExecutionExceptions and need to be unwrapped before they can be identified as ResolvableApiException. This commit addresses both issues by making waitForSms a proper coroutine using withContext and a custom wrapper around Task<T> that relies on suspendCoroutine and automatically unwraps exceptions. (cherry picked from commit 3afeff45d8bd5fff66e1d0fa2c15fa2527487af1)
2020-07-30Fix TOTP import button check semantics (#982)Harsh Shandilya
* Improve TOTP checking semantics Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Fix return label Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * update CHANGELOG Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Move updateViewState() call outside with(binding) scope Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit ecf96aa0668a758b2408284facda41ac70fe10aa)
2020-07-30Properly handle files without passwords (#969)Harsh Shandilya
* Properly handle files without passwords Fixes #967 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Fix tests Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Only look for TOTP URI Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit 62dbc183d52d93860228316b209ec5aa15f16a08)
2020-07-30Expand OTP and PasswordEntry tests (#968)Harsh Shandilya
(cherry picked from commit e3cf73885c112bc553d6a0cc01d594a87728f448)
2020-07-23Wire in fallback key selection flow (#958)Harsh Shandilya
Co-authored-by: Fabian Henneke <fabian@henneke.me> (cherry picked from commit 084b833fa49a583433284f0173cb7342152b263b)
2020-07-23Fix OpenPgpApi extra type confusion (#960)Fabian Henneke
(cherry picked from commit da167599d2d7f387daf62bbc51720577de30e7ad)
2020-07-23Fix a crash when parsing long key IDs (#959)Fabian Henneke
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit fbd84fde3a25d23cbf51fe0cd609ce9bd13836cc)
2020-07-22Add pt-BR translations and cleanup resources (#947)Harsh Shandilya
2020-07-20Use a more common SSH version string (#944)Fabian Henneke
2020-07-19Fix Autofill result contract bug (#941)Fabian Henneke
2020-07-19Improve UI when launching with biometric lock (#940)Harsh Shandilya
2020-07-19Remove type images (#939)Harsh Shandilya
* Remove type images Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-19Always allow SSH key generation (#938)Harsh Shandilya
2020-07-16Remove manual key selection and start actually using `.gpg-id` (#916)Harsh Shandilya
Co-authored-by: Aditya Wasan <adityawasan55@gmail.com> Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-07-16Fix overly large horizontal margins on material switches (#935)Fabian Henneke
* Fix overly large horizontal margins on material switches * Increase icon size for autofill filter view Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-14Add debug icon and update color palette (#931)Harsh Shandilya
2020-07-14Revert "Work around Chrome Autofill issue (#921)" (#933)Fabian Henneke
2020-07-14Properly guard against invalid renaming (#929)Harsh Shandilya
2020-07-14Fix navigation bar theming and reformat (#930)Harsh Shandilya
2020-07-09Move password export to the IO dispatcher (#918)Harsh Shandilya
* Move password export to the IO dispatcher Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Simplify snackbars and disable exit operations during export Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Move export password logic to service Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Reformat Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Use explicit null check Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unneeded hack Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Fixup strings Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Don't use coroutines in a service Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Update notification icon Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Rollback unwanted formatting Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2020-07-08global: set an import order rule and reformat with it (#924)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-07styles: re-add alertDialogTheme override (#923)Harsh Shandilya
It seems the MaterialComponents inflater does not work with preferences. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-07Work around Chrome Autofill issue (#921)Fabian Henneke
2020-07-07Major UI overhaul and the introduction of a new icon (#920)Harsh Shandilya
Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-07-04Update Public Suffix List data (#917)github-actions[bot]
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-07-03Migrate to ActivityResultContracts (#910)Harsh Shandilya
* Move git directory selection to ActivityResultContracts Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * global: replace all android.app.Activity references Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * res: resolve ObsoleteSdkInt lint warning Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * layout: silence some overdraw warnings Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * PasswordFragment: address deprecation Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * PasswordStore: start addressing deprecation warnings Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * autofill: silence deprecation warnings for legacy implementation I don't want to ever touch these files Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Reset scrollTarget after use Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Refresh password list after each swipe Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Convert if to when Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Migrate UserPreference to ActivityResultContracts Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Also validate result in git directory selection Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * AutofillSaveActivity: Switch to ActivityResultContracts Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * AutofillDecryptActivity: Switch to ActivityResultContracts Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * AutofillFilterActivity: Switch to ActivityResultContracts Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Improve deletion flow - Silently delete empty directory - Always refresh password list upon completion Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Uniform naming for activity result handlers Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
2020-07-02Fill OTP fields with SMS codes (#900)Fabian Henneke
* Fill OTP fields with SMS codes * Allow SMS OTP fill also for web origins * Introduce free and nonFree build variants * Fix up workflow * Improve layout and feature detection * Workflow changes * Add Changelog entry * github: update release workflow for nonFree/Free split Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Switch to lifecycleScope * github: make snapshot deploy free variant Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-07-02Fix up URIish instances with @ in user name (#913)Fabian Henneke
2020-07-01Scroll to files and enter folders when created (#909)Fabian Henneke
2020-07-01Run a treewide reformat (#908)Fabian Henneke
Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-07-01Improve and refactor Autofill heuristics (#905)Fabian Henneke
* Add support for `AUTOFILL_HINT_NEW_PASSWORD` and `AUTOFILL_HINT_NEW_USERNAME`. This allows apps to trigger a `ClassifiedScenario` with only a generate password action and is the analogue of the W3C new-password hint for websites. * Do not consider HTML password fields without hints to be certain password fields (they could contain e.g. bank account numbers, API secrets,...). * Reduce OTP field false positives by excluding the term "postal" as well as fields that match the "code" heuristic term but have HTML maxLength less than 6 or larger than 8. * Add German heuristic term "einmal" ("one-time") for OTP fields * Also exclude fields based on their HTML name (e.g. for terms such as "search"). * Extract fieldId, hint and htmlName matches into an extension property. * Reduce warnings and remove unnecessary suppression annotations.
2020-07-01Use PreferenceKeys file to manage SharedPreferences keys. (#891)Aditya Wasan
* Use PreferenceKeys file to manage SharedPreferences keys. Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Use PreferenceKeys in all files Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Divide PreferenceKeys into multiple regions Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Fix build error Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Use PreferenceKeys in more files Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Reformat code Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Fix build error Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Fix merge issues Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-06-30Revert "Support directly importing secrets" (#904)Harsh Shandilya
2020-06-30Allow importing TOTP configuration through QR codes (#903)Harsh Shandilya
Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-06-30Workaround to prevent crash on first run (#898)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-29Offer TOTP Autofill for OTP fields (#899)Fabian Henneke
2020-06-29Merge SshKeyGenFragment into its activity (#897)Harsh Shandilya
* Merge SshKeyGenFragment into its activity Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Drop neutral button discouraged by material specs Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-29Reintroduce TOTP support (#890)Harsh Shandilya
Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-06-28Consolidate password list refresh (#887)Fabian Henneke
2020-06-28UI fixups (#892)Harsh Shandilya
2020-06-27Update Public Suffix List data (#888)github-actions[bot]
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-06-26Use remembered credential even if it is empty (#880)Fabian Henneke
* Use remembered credential even if it is empty Should fix #875. * .isNull() --> == null * Update relnotes Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Reword relnotes Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * 2019 it is Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-26Reset SSH passphrase after SSH key import (#885)Fabian Henneke
2020-06-26Prevent cached passwords from being wiped (#884)Fabian Henneke
2020-06-23Use a custom sshj config (#878)Fabian Henneke
* Use a custom sshj config * Get random numbers directly from SecureRandom * Use Timber calls for logging * Remove all algorithms that are not in the Mozilla Intermediate SSH config * Address review comments * Fixup slf4j's custom format string format Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-06-22Add org.gnu.icecat as a trusted multi-origin browser (#871)Fabian Henneke
I verified the following: * Store: F-Droid * Package hash: wi2iuVvK/WYZUzd2g0Qzn9ef3kAisQURZ8U1WSMTkcM= * Based on: Firefox * Actively maintained: https://git.savannah.gnu.org/cgit/gnuzilla.git/log/?h=68 * Multi-origin method: WebView * Save support: no
2020-06-21PasswordCreationActivity: properly guard rename codeHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-06-20UserPreference: fix my inability to count (#863)Harsh Shandilya
2020-06-20Update Public Suffix List data (#864)github-actions[bot]
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-06-19PasswordStore: refresh password list on swipe down in non-git mode (#862)Harsh Shandilya
* PasswordStore: refresh password list on swipe down in non-git mode Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>