aboutsummaryrefslogtreecommitdiff
path: root/app/src
AgeCommit message (Collapse)Author
2021-03-06Disallow overwriting passwords when editing (#1286)Harsh Shandilya
Co-authored-by: Aditya Wasan <adityawasan55@gmail.com> (cherry picked from commit 1f8db46ade8a7c25deb568b8a5988ee7b340b9c1)
2020-12-21Sync localisations with Crowdin (#1256)Harsh Shandilya
Fixes #1254 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit 37c8b416d5ed657e89878b5f28394fa4640294e9) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21Transform broken repo error message to be more helpful (#1251)Harsh Shandilya
(cherry picked from commit 0396bf92a9a15bcdac8b9fc71f6b34afc949ab41) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21Better guidance for users to deal with host key changes (#1242)Harsh Shandilya
* Provide actionable guidance for host key mismatches Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Hide host key clear button after use Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit ce2e657108187a34416cfbfc0c5d2fc8bb9277f3) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21Set 10 second timeout on JGit transport commands (#1230)Harsh Shandilya
* GitOperation: set a 10 second connection timeout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit 77e77be999ed45dfccf1c3db838821442931eff4) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21GitCommandExecutor: make committer match author (#1226)Harsh Shandilya
* GitCommandExecutor: make committer match author Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Add changelog entry Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit 31a11a1ebb54ec88d13004c6b4669d7501724909) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21Try to fix missing `.gpg-id` files as well (#1246)Harsh Shandilya
(cherry picked from commit c02ad427be3652298f4a07a5f1a0d68e4ac44c45) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21Mark Chrome Canary as non-flaky and allowing save (#1237)Fabian Meumertzheim
* Mark Chrome Canary as non-flaky and allowing save * autofill-parser: update API dump Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * autofill-parser: bump snapshot version Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit 2e43d77c5c72a0111445317a3d88e53a8b4b6782) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21Automatically dismiss decryption screen after 60 seconds (#1216)Harsh Shandilya
* Automatically dismiss decryption screen after 60 seconds Fixes #1215 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit a9c73f1e517d6e308ff78784daf1a88f74d55cce) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21App shortcut fixes (#1213)Harsh Shandilya
(cherry picked from commit 544631da04c38ef734f34ceed31071a551876929) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21Fix Autofill dataset icon tint (#1207)Fabian Henneke
ImageViews in RemoteViews require tint to be specified with the android: prefix, the lint thinks otherwise. (cherry picked from commit 02c853c3b1124d8d37c357f7040abd579c51bf8a) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-12-21Fix extra content for multiple username fields (#1192)Harsh Shandilya
Fixes #1190 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit df6ebfee27597887075b94a945e707ecd69decb1)
2020-12-21Finish activity when Autofill Generate is cancelled (#1179)Fabian Henneke
(cherry picked from commit 03959cca4d401487b6422cd0d650e7486af0b129) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-23Minimal support for MIME secret encoding (#1170)Joris Minjat
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com> (cherry picked from commit 38ece10e0dfdc907089b7ddc4e6c9d17e69013f3)
2020-10-23Workaround AndroidX lifecycle requirements in OpenKeychain auth (#1168)Harsh Shandilya
* Workaround AndroidX lifecycle requirements in OpenKeychain auth Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * CHANGELOG: add OpenKeychain fix Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com> (cherry picked from commit 66b31f1432a1405143323f92ca7e33d6c98ee0a2)
2020-10-23Revert "Add option to automatically sync repository on app launch (#1137)"Harsh Shandilya
Fixes #1163 This reverts commit 92f1aab25da12411aa256c3b763e0cb6182e9320. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> (cherry picked from commit 4905396c673dcfdf076c530a1cbb5be800e0920f)
2020-10-21GitServerConfigActivity: add quick-fix for HTTPS URLs with custom portsHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-21GitServerConfigActivity: set auth mode visibility on launch as wellHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-19Convert PasswordRepository to an objectHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-19PasswordRepository: split out PasswordSortOrderHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-19PasswordStore: Remove unnecessary class-level variablesHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-18Rollback string changes from #1157Harsh Shandilya
These should never have been made Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-17Use BottomSheet in place of Snackbar for longer messages (#1157)ashoksinghal
2020-10-16Revamp build configuration (#1156)Harsh Shandilya
* release: move scripts to scripts directory Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Move CI secrets to secrets directory Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * gradle: uprev to 6.7 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * gradle: suppress warnings about unsupported options Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: update dependencies Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: move Gradle plugins to ext Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: move configuration tasks to buildSrc Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * CHANGELOG: add entry for #1137 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Fix lint warnings Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-15Add option to automatically sync repository on app launch (#1137)Aditya Wasan
* Add option to automatically sync repository on app launch Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Pull repo if user is not authenticated Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Hijack incoming intent rather than copying it Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Initialize password repository before using it Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-11ProxyUtils: correctly handle the 'no proxy' case (#1148)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-10res: merge unneeded override into base fileHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-08Temporarily work around SSHJ compatibility issues (#1142)Fabian Henneke
Using ECDSA either as a key exchange or a host key algorithm fails with SSHJ 0.30.0 on Android, but should again become possible in 0.31.0. While we wait for the release, demote ECDSA in the list of key algorithms (as it should still be available for public key auth) and remove it from the list of key exchange algorithms.
2020-10-08Introduce app-wide HTTPS proxy setting (#1134)Harsh Shandilya
2020-10-06Show new FillResponse right after publisher reset (#1138)Fabian Henneke
If Autofill shows a warning about an app whose publisher changed and the user decides to trust the app and clear previous matches, they should immediately be given the option to select a new match. Previously, as AutofillPublisherChangedActivity did not return a result, the old FillResponse with just a warning would be reused. We now pass a useful response with no matches on to the activity, which returns it after the user has chosen to reset the publisher info.
2020-10-06Fix Autofill publisher changed layout (#1136)Harsh Shandilya
* Fix Autofill publisher changed layout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Tweak autofill publisher UI Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2020-10-05Resolve lock contention from lazy delegates (#1135)Harsh Shandilya
2020-10-02all: refactor ActivityResultContracts usages to adhere to API requirementsHarsh Shandilya
The newest versions of AndroidX Activity and Fragments correctly enforce the requirement for all contracts to be registered at class init or before the lifecycle has reached `Lifecycle.State.STARTED`. To comply with these requirements, move all instances of `registerForActivityResult` being called at arbitrary points in the code to be done at class init. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-02build: uprev dependenciesHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01Add key selection step to onboarding flowHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01PasswordCreationActivity: tweak logic for determining if identifier ↵Harsh Shandilya
selection is needed Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-10-01Make unset author/email behavior match GitHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-29Unwrap root cause for InvalidRemoteException (#1122)Harsh Shandilya
* BaseGitActivity: unwrap root cause for InvalidRemoteException as well JGit's InvalidRemoteException, like TransportException, swallows more useful errors as is clear from this (redacted) snippet. ``` D org.eclipse.jgit.api.errors.InvalidRemoteException: Invalid remote: origin D at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:26) D at org.eclipse.jgit.api.PullCommand.call(PullCommand.java:41) D at com.zeapo.pwdstore.git.GitCommandExecutor$execute$2$result$1.invokeSuspend(GitCommandExecutor.kt:2) D at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3) D at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:15) D at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:1) D at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:13) D Caused by: org.eclipse.jgit.errors.NoRemoteRepositoryException: ssh://msfjarvis@[fe80::dead:beef]:22/pass-repo: fatal: '/pass-repo' does not appear to be a git repository D at org.eclipse.jgit.transport.TransportGitSsh.cleanNotFound(TransportGitSsh.java:14) D at org.eclipse.jgit.transport.TransportGitSsh$SshFetchConnection.<init>(TransportGitSsh.java:20) D at org.eclipse.jgit.transport.TransportGitSsh.openFetch(TransportGitSsh.java:1) D at org.eclipse.jgit.transport.FetchProcess.executeImp(FetchProcess.java:1) D at org.eclipse.jgit.transport.Transport.fetch(Transport.java:20) D at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:18) ``` Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Add changelog entry Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-24Restore settings button to onboarding screen (#1119)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-22Sync strings from Crowdin (#1117)Harsh Shandilya
* strings: sync from Crowdin Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: disable ImpliedQuantity lint I hope our translators know better Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-21Remove Autofill onboarding prompt and cleanup strings (#1116)Harsh Shandilya
2020-09-21Refactor auth mode check/uncheck (#1115)Harsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19Add check for potential issues with SSH URLHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19BasicBottomSheet: initHarsh Shandilya
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19Finish activity in case of external directory (#1110)Aditya Wasan
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-09-18Misc cleanups to build and extension functions (#1108)Harsh Shandilya
2020-09-18Add annotation to WelcomeFragment class (#1107)Aditya Wasan
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-09-16Autofill: Extract AutofillParser into separate subproject (#1101)Vincent Breitmoser
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-09-15Update on-boarding UI (#1099)Aditya Wasan
* Add onboarding flow from v2 Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Minor fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Add changelog entry Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Remove old activity from manifest Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Remove view type prefix from view ids Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Review fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Treewide: Reformat code Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Moar review fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Revert "Treewide: Reformat code" This reverts commit 348ef0050942526a55890b245afec8d7fee4d81e. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * onboarding: cleanup OnboardingActivity init Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unused layout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unnecessary ConstraintLayout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Shorten animation duration Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * onboarding: use viewBinding extension in fragments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-14Add tentative workaround for dialog crashes and refactor Git-related code ↵Harsh Shandilya
(#1100) * Ensure we're creating dialogs on the main thread Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unused operation type Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Refactor launchGitOperation to use an enum Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>