summaryrefslogtreecommitdiff
path: root/app/lint-baseline.xml
blob: cbf1295c734d5c9b10d9e099914641e87fd3b7ec (about) (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.2.0-alpha06" type="baseline" client="gradle" dependencies="false" name="AGP (8.2.0-alpha06)" variant="all" version="8.2.0-alpha06">

    <issue
        id="StopShip"
        message="`TODO` call found; points to code which must be fixed prior to release"
        errorLine1="        is Err -> TODO()"
        errorLine2="                  ~~~~~~">
        <location
            file="src/main/java/app/passwordstore/util/viewmodel/PGPKeyListViewModel.kt"
            line="35"
            column="19"/>
    </issue>

    <issue
        id="InvalidPackage"
        message="Invalid package reference in org.bouncycastle:bcpkix-jdk15to18; not included in Android: `javax.naming.directory`. Referenced from `org.bouncycastle.cert.dane.fetcher.JndiDANEFetcherFactory`.">
        <location
            file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.bouncycastle/bcpkix-jdk15to18/1.73/7673fe0f3510e88232c4bd98d027e9e0a3d0af6d/bcpkix-jdk15to18-1.73.jar"/>
    </issue>

    <issue
        id="InvalidPackage"
        message="Invalid package reference in org.bouncycastle:bcpkix-jdk15to18; not included in Android: `javax.naming`. Referenced from `org.bouncycastle.cert.dane.fetcher.JndiDANEFetcherFactory.1`.">
        <location
            file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.bouncycastle/bcpkix-jdk15to18/1.73/7673fe0f3510e88232c4bd98d027e9e0a3d0af6d/bcpkix-jdk15to18-1.73.jar"/>
    </issue>

    <issue
        id="RawDispatchersUse"
        message="Use SlackDispatchers."
        errorLine1="      runBlocking(Dispatchers.Main) { suspendCoroutine { cont -> askForPassword(cont, isRetry) } }"
        errorLine2="                  ~~~~~~~~~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/util/git/sshj/SshjSessionFactory.kt"
            line="60"
            column="19"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
        errorLine1="      model.searchResult"
        errorLine2="      ^">
        <location
            file="src/main/java/app/passwordstore/ui/autofill/AutofillFilterView.kt"
            line="199"
            column="7"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
        errorLine1="        entry.totp.onEach(adapter::updateOTPCode).launchIn(lifecycleScope)"
        errorLine2="        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/ui/crypto/DecryptActivity.kt"
            line="271"
            column="9"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
        errorLine1="    merge("
        errorLine2="    ^">
        <location
            file="src/main/java/app/passwordstore/ui/dialogs/DicewarePasswordGeneratorDialogFragment.kt"
            line="50"
            column="5"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="Use Context#getDrawableCompat() instead"
        errorLine1="                ContextCompat.getDrawable(itemView.context, R.drawable.ic_content_copy)"
        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/ui/adapters/FieldItemAdapter.kt"
            line="67"
            column="17"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="Use Context#getDrawableCompat() instead"
        errorLine1="                ContextCompat.getDrawable(itemView.context, R.drawable.ic_content_copy)"
        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/ui/adapters/FieldItemAdapter.kt"
            line="67"
            column="17"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
        errorLine1="    model.searchResult"
        errorLine2="    ^">
        <location
            file="src/main/java/app/passwordstore/ui/passwords/PasswordFragment.kt"
            line="182"
            column="5"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
        errorLine1="    merge("
        errorLine2="    ^">
        <location
            file="src/main/java/app/passwordstore/ui/dialogs/PasswordGeneratorDialogFragment.kt"
            line="58"
            column="5"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="For a stack use ArrayDeque which is more efficient internally."
        errorLine1="  private val navigationStack = Stack&lt;NavigationStackEntry>()"
        errorLine2="                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/util/viewmodel/SearchableRepositoryViewModel.kt"
            line="297"
            column="33"/>
    </issue>

    <issue
        id="DenyListedApi"
        message="Use the structured concurrent CoroutineScope#launch and Flow#collect APIs instead of reactive Flow#onEach and Flow#launchIn. Suspend calls like Flow#collect can be refactored into standalone suspend funs and mixed in with regular control flow in a suspend context, but calls that invoke CoroutineScope#launch and Flow#collect at the same time hide the suspend context, encouraging the developer to continue working in the reactive domain."
        errorLine1="    model.searchResult"
        errorLine2="    ^">
        <location
            file="src/main/java/app/passwordstore/ui/folderselect/SelectFolderFragment.kt"
            line="62"
            column="5"/>
    </issue>

    <issue
        id="MissingQuantity"
        message="For locale &quot;it&quot; (Italian) the following quantity should also be defined: `many`"
        errorLine1="  &lt;plurals name=&quot;delete_title&quot;>"
        errorLine2="  ^">
        <location
            file="src/main/res/values-it/strings.xml"
            line="7"
            column="3"/>
    </issue>

    <issue
        id="MissingQuantity"
        message="For locale &quot;pt&quot; (Portuguese) the following quantity should also be defined: `many`"
        errorLine1="  &lt;plurals name=&quot;delete_title&quot;>"
        errorLine2="  ^">
        <location
            file="src/main/res/values-pt-rBR/strings.xml"
            line="7"
            column="3"/>
    </issue>

    <issue
        id="MissingQuantity"
        message="For locale &quot;it&quot; (Italian) the following quantity should also be defined: `many`"
        errorLine1="  &lt;plurals name=&quot;delete_dialog_text&quot;>"
        errorLine2="  ^">
        <location
            file="src/main/res/values-it/strings.xml"
            line="21"
            column="3"/>
    </issue>

    <issue
        id="MissingQuantity"
        message="For locale &quot;pt&quot; (Portuguese) the following quantity should also be defined: `many`"
        errorLine1="  &lt;plurals name=&quot;delete_dialog_text&quot;>"
        errorLine2="  ^">
        <location
            file="src/main/res/values-pt-rBR/strings.xml"
            line="21"
            column="3"/>
    </issue>

    <issue
        id="ConvertToWebp"
        message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
        <location
            file="src/debug/res/mipmap-xxxhdpi/ic_launcher.png"/>
    </issue>

    <issue
        id="ConvertToWebp"
        message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
        <location
            file="src/main/res/mipmap-xxxhdpi/ic_launcher.png"/>
    </issue>

    <issue
        id="SelectableText"
        message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
        errorLine1="  &lt;TextView"
        errorLine2="   ~~~~~~~~">
        <location
            file="src/main/res/layout/activity_oreo_autofill_filter.xml"
            line="27"
            column="4"/>
    </issue>

    <issue
        id="SelectableText"
        message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
        errorLine1="  &lt;TextView"
        errorLine2="   ~~~~~~~~">
        <location
            file="src/main/res/layout/activity_oreo_autofill_publisher_changed.xml"
            line="66"
            column="4"/>
    </issue>

    <issue
        id="SelectableText"
        message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
        errorLine1="  &lt;TextView"
        errorLine2="   ~~~~~~~~">
        <location
            file="src/main/res/layout/activity_oreo_autofill_publisher_changed.xml"
            line="81"
            column="4"/>
    </issue>

    <issue
        id="SelectableText"
        message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
        errorLine1="    &lt;TextView"
        errorLine2="     ~~~~~~~~">
        <location
            file="src/main/res/layout/oreo_autofill_dataset.xml"
            line="37"
            column="6"/>
    </issue>

    <issue
        id="SelectableText"
        message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
        errorLine1="    &lt;TextView"
        errorLine2="     ~~~~~~~~">
        <location
            file="src/main/res/layout/oreo_autofill_dataset.xml"
            line="46"
            column="6"/>
    </issue>

    <issue
        id="SelectableText"
        message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
        errorLine1="  &lt;TextView"
        errorLine2="   ~~~~~~~~">
        <location
            file="src/main/res/layout/oreo_autofill_filter_row.xml"
            line="29"
            column="4"/>
    </issue>

    <issue
        id="SelectableText"
        message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
        errorLine1="  &lt;TextView"
        errorLine2="   ~~~~~~~~">
        <location
            file="src/main/res/layout/oreo_autofill_filter_row.xml"
            line="43"
            column="4"/>
    </issue>

    <issue
        id="ComposeUnstableCollections"
        message="The Compose Compiler cannot infer the stability of a parameter if a List&lt;GpgIdentifier> is used in it, even if the item type is stable.&#xA;You should use Kotlinx Immutable Collections instead: `identifiers: ImmutableList&lt;GpgIdentifier>` or create an `@Immutable` wrapper for this class: `@Immutable data class IdentifiersList(val items: List&lt;GpgIdentifier>)`&#xA;See https://slackhq.github.io/compose-lints/rules/#avoid-using-unstable-collections for more information."
        errorLine1="  identifiers: List&lt;GpgIdentifier>,"
        errorLine2="               ~~~~~~~~~~~~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/ui/pgp/PGPKeyList.kt"
            line="36"
            column="16"/>
    </issue>

    <issue
        id="UnknownNullness"
        message="Should explicitly declare type here since implicit type does not specify nullness (Lazy&lt;Array&lt;(GitCommand&lt;out (Any or Any?)> or GitCommand&lt;out (Any or Any?)>?)>>)"
        errorLine1="  override val commands by unsafeLazy {"
        errorLine2="               ~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/util/git/operation/BreakOutOfDetached.kt"
            line="33"
            column="16"/>
    </issue>

    <issue
        id="UnknownNullness"
        message="Should explicitly declare type here since implicit type does not specify nullness (Array&lt;(GitCommand&lt;out (Any or Any?)> or GitCommand&lt;out (Any or Any?)>?)>)"
        errorLine1="  override val commands ="
        errorLine2="               ~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/util/git/operation/ResetToRemoteOperation.kt"
            line="14"
            column="16"/>
    </issue>

    <issue
        id="UnknownNullness"
        message="Should explicitly declare type here since implicit type does not specify nullness (Array&lt;(GitCommand&lt;out (Any or Any?)> or GitCommand&lt;out (Any or Any?)>?)>)"
        errorLine1="  override val commands ="
        errorLine2="               ~~~~~~~~">
        <location
            file="src/main/java/app/passwordstore/util/git/operation/SyncOperation.kt"
            line="14"
            column="16"/>
    </issue>

</issues>