diff options
| author | Harsh Shandilya <me@msfjarvis.dev> | 2022-10-21 21:36:27 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-21 21:36:27 +0530 |
| commit | cdf0f30c61e55fc94524c2fd3f07ffda367555f1 (patch) | |
| tree | f1d4a029c78105560947def5a3d5c423f4b096d0 /detekt-baselines | |
| parent | df764932f7fdddea9cea5937c6053a95797d35df (diff) | |
Refactor `format-common` module (#2196)
* fix: touch up `PasswordEntryTest` KDoc
* feat: add format-common-impl module
* refactor: switch app to format-common-impl
* refactor: move `format-common` tests to `format-common-impl`
* feat: add a test for Steam OTP
Diffstat (limited to 'detekt-baselines')
| -rw-r--r-- | detekt-baselines/app.xml | 3 | ||||
| -rw-r--r-- | detekt-baselines/format-common-impl.xml | 7 |
2 files changed, 7 insertions, 3 deletions
diff --git a/detekt-baselines/app.xml b/detekt-baselines/app.xml index 5a5f9df9..4ef4ba76 100644 --- a/detekt-baselines/app.xml +++ b/detekt-baselines/app.xml @@ -14,7 +14,6 @@ <ID>ComplexMethod:PasswordCreationActivity.kt$PasswordCreationActivity$override fun onCreate(savedInstanceState: Bundle?)</ID> <ID>ComplexMethod:PasswordCreationActivity.kt$PasswordCreationActivity$private fun encrypt()</ID> <ID>ComplexMethod:PasswordFragment.kt$PasswordFragment$private fun initializePasswordList()</ID> - <ID>EmptyDoWhileBlock:PasswordDialog.kt$PasswordDialog${}</ID> <ID>EmptyFunctionBlock:BasicBottomSheet.kt$BasicBottomSheet.<no name provided>${}</ID> <ID>EmptyFunctionBlock:ItemCreationBottomSheet.kt$ItemCreationBottomSheet.<no name provided>${}</ID> <ID>EmptyFunctionBlock:PasswordFragment.kt$PasswordFragment.<no name provided>.<no name provided>${}</ID> @@ -58,7 +57,6 @@ <ID>MagicNumber:SshKey.kt$SshKey.Algorithm.Ecdsa$256</ID> <ID>MagicNumber:SshKey.kt$SshKey.Algorithm.Rsa$3072</ID> <ID>MagicNumber:SshjSessionFactory.kt$SshjSession$22</ID> - <ID>MagicNumber:UriTotpFinder.kt$UriTotpFinder$30</ID> <ID>MatchingDeclarationName:AutofillViewUtils.kt$DatasetMetadata</ID> <ID>MaxLineLength:BaseGitActivity.kt$BaseGitActivity$"The server does not support multiple Git operations per SSH session. Please try again, a slower fallback mode will be used."</ID> <ID>MaxLineLength:BaseGitActivity.kt$BaseGitActivity$"WARNING: The remote host key has changed. If this is expected, please go to Git server settings and clear the saved host key."</ID> @@ -82,7 +80,6 @@ <ID>ReturnCount:OreoAutofillService.kt$OreoAutofillService$override fun onSaveRequest(request: SaveRequest, callback: SaveCallback)</ID> <ID>ReturnCount:PasswordStore.kt$PasswordStore$override fun onKeyDown(keyCode: Int, event: KeyEvent): Boolean</ID> <ID>ReturnCount:ShortcutHandler.kt$ShortcutHandler$fun addPinnedShortcut(item: PasswordItem, intent: Intent)</ID> - <ID>ReturnCount:UriTotpFinder.kt$UriTotpFinder$override fun findSecret(content: String): String?</ID> <ID>SpreadOperator:Api30AutofillResponseBuilder.kt$Api30AutofillResponseBuilder$(*ignoredIds.toTypedArray())</ID> <ID>SpreadOperator:AutofillResponseBuilder.kt$AutofillResponseBuilder$(*ignoredIds.toTypedArray())</ID> <ID>SpreadOperator:BreakOutOfDetached.kt$BreakOutOfDetached$( // abort the rebase git.rebase().setOperation(RebaseCommand.Operation.ABORT), *resetCommands, )</ID> diff --git a/detekt-baselines/format-common-impl.xml b/detekt-baselines/format-common-impl.xml new file mode 100644 index 00000000..5a23ddfe --- /dev/null +++ b/detekt-baselines/format-common-impl.xml @@ -0,0 +1,7 @@ +<?xml version="1.0" ?> +<SmellBaseline> + <ManuallySuppressedIssues></ManuallySuppressedIssues> + <CurrentIssues> + <ID>ReturnCount:UriTotpFinder.kt$UriTotpFinder$override fun findSecret(content: String): String?</ID> + </CurrentIssues> +</SmellBaseline> |